search

aquarist-labs / aquarium

Project Aquarium is a SUSE-sponsored open source project aiming at becoming an easy to use, rock solid storage appliance based on Ceph.
https://aquarist-labs.io/
Other
71 stars 23 forks source link

gravel: allow passing custom registry as env vars #735

Closed jecluis closed 3 years ago

jecluis commented 3 years ago

By specifying

  AQUARIUM_REGISTRY_URL=<URL>
  AQUARIUM_REGISTRY_IMAGE=<NAME>
  AQUARIUM_REGISTRY_SECURE=<true|false>

as environment variables, we can specify a custom registry directly to the aquarium service without having to configure it through the UI or the API.

Extremely helpful during development.

Signed-off-by: Joao Eduardo Luis \joao@suse.com

codecov-commenter commented 3 years ago

Codecov Report

Merging #735 (0ebe981) into main (61367fd) will increase coverage by 0.15%. The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
+ Coverage   69.51%   69.66%   +0.15%     
==========================================
  Files          30       30              
  Lines        3064     3086      +22     
==========================================
+ Hits         2130     2150      +20     
- Misses        934      936       +2
Impacted Files Coverage Δ
src/gravel/controllers/config.py 97.82% <91.30%> (-2.18%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61367fd...0ebe981. Read the comment docs.