aquarist-labs / aquarium

Project Aquarium is a SUSE-sponsored open source project aiming at becoming an easy to use, rock solid storage appliance based on Ceph.
https://aquarist-labs.io/
Other
71 stars 23 forks source link

gravel: Ignore gravel/cephadm in tox #746

Closed votdev closed 3 years ago

votdev commented 3 years ago

Ignore gravel/cephadm in our tox configuration to prevent messages like this:

lint installed: black==21.10b0,click==8.0.3,isort==5.10.0,mypy-extensions==0.4.3,pathspec==0.9.0,platformdirs==2.4.0,regex==2021.11.2,tomli==1.2.2,typing-extensions==3.10.0.2
lint run-test-pre: PYTHONHASHSEED='1723414377'
lint run-test: commands[0] | black --check --diff aquarium.py gravel
All done! ✨ 🍰 ✨
67 files would be left unchanged.
lint run-test: commands[1] | isort --check-only --diff aquarium.py gravel
ERROR: /home/vot/git/aquarium/src/gravel/cephadm/cephadm.bin Imports are incorrectly sorted and/or formatted.
--- /home/vot/git/aquarium/src/gravel/cephadm/cephadm.bin:before    2021-11-08 10:52:34.422673
+++ /home/vot/git/aquarium/src/gravel/cephadm/cephadm.bin:after 2021-11-08 16:44:33.527913
@@ -1,46 +1,58 @@
 #!/usr/bin/python3

+import argparse
 import asyncio
 import asyncio.subprocess
-import argparse
 import datetime
+import errno
...
 try:
-    from asyncio import run as async_run   # type: ignore[attr-defined]
+    from asyncio import run as async_run  # type: ignore[attr-defined]
 except ImportError:
     def async_run(coro):  # type: ignore
         loop = asyncio.new_event_loop()
ERROR: InvocationError for command /home/vot/git/aquarium/src/.tox/lint/bin/isort --check-only --diff aquarium.py gravel (exited with code 1)
__________________________________________________ summary __________________________________________________
  py3: commands succeeded
ERROR:   mypy: commands failed
ERROR:   lint: commands failed

Signed-off-by: Volker Theile vtheile@suse.com

Checklist


Show available Jenkins commands - `jenkins run tumbleweed` - `jenkins run leap` - `jenkins run ubuntu`
codecov-commenter commented 3 years ago

Codecov Report

Merging #746 (dc3fa72) into main (218752f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #746   +/-   ##
=======================================
  Coverage   69.79%   69.79%           
=======================================
  Files          30       30           
  Lines        3115     3115           
=======================================
  Hits         2174     2174           
  Misses        941      941           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 028385c...dc3fa72. Read the comment docs.