aquarist-labs / aquarium

Project Aquarium is a SUSE-sponsored open source project aiming at becoming an easy to use, rock solid storage appliance based on Ceph.
https://aquarist-labs.io/
Other
71 stars 23 forks source link

glass: Rename datatable column property 'unsortable' to 'sortable' #749

Closed votdev closed 2 years ago

votdev commented 3 years ago

Naming this property 'sortable' is more common practice than 'unsortable'. The new name is also more intuitive.

Signed-off-by: Volker Theile vtheile@suse.com

Checklist


Show available Jenkins commands - `jenkins run tumbleweed` - `jenkins run leap` - `jenkins run ubuntu`
codecov-commenter commented 3 years ago

Codecov Report

Merging #749 (1dbcb2a) into main (e72d816) will increase coverage by 0.34%. The diff coverage is n/a.

:exclamation: Current head 1dbcb2a differs from pull request most recent head cb409bc. Consider uploading reports for the commit cb409bc to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
+ Coverage   69.79%   70.13%   +0.34%     
==========================================
  Files          30       30              
  Lines        3115     3171      +56     
==========================================
+ Hits         2174     2224      +50     
- Misses        941      947       +6     
Impacted Files Coverage Δ
src/gravel/controllers/nodes/deployment.py 66.84% <0.00%> (+0.08%) :arrow_up:
src/gravel/controllers/containers.py 64.77% <0.00%> (+31.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e72d816...cb409bc. Read the comment docs.