gravel: deployment rework

[jecluis]

This patch set reworks how we do the install and deployment phase for seed nodes and nodes joining the network.

While it works as it is, all unit tests are broken. This needs considerable validation still. And there are known, minor bugs.

Additionally, requires a rebase on top of current main.

This work won't be complete until the frontend is also adjusted.

Consider this a draft, up for review up until this point.

Signed-off-by: Joao Eduardo Luis \joao@suse.com

[github-actions[bot]]

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

[votdev]

The deployment fails with the following error message:

INFO:     2021-12-03 10:59:55 -- create -- Bootstrap complete with success.
DEBUG:    2021-12-03 10:59:58 -- create -- Create progress: 85%, Configuring deployment.
ERROR:    2021-12-03 11:01:10 -- ceph -- error running command: rc = -2, reason = all mgr daemons do not support module 'bubbles', pass --force to force enablement
ERROR:    2021-12-03 11:01:10 -- ceph -- unable to enable module bubbles: all mgr daemons do not support module 'bubbles', pass --force to force enablement
ERROR:    2021-12-03 11:04:10 -- create -- Unable to start Bubbles.
ERROR:    2021-12-03 11:04:16 -- create -- Create error: Failed configuring the deployment.

[jecluis]

The deployment fails with the following error message:

INFO:     2021-12-03 10:59:55 -- create -- Bootstrap complete with success.
DEBUG:    2021-12-03 10:59:58 -- create -- Create progress: 85%, Configuring deployment.
ERROR:    2021-12-03 11:01:10 -- ceph -- error running command: rc = -2, reason = all mgr daemons do not support module 'bubbles', pass --force to force enablement
ERROR:    2021-12-03 11:01:10 -- ceph -- unable to enable module bubbles: all mgr daemons do not support module 'bubbles', pass --force to force enablement
ERROR:    2021-12-03 11:04:10 -- create -- Unable to start Bubbles.
ERROR:    2021-12-03 11:04:16 -- create -- Create error: Failed configuring the deployment.

This is likely because you're using the default registry and image, which currently doesn't support bubbles. For this to actually succeed you need to provide a custom registry with a bubbles container.

[jecluis]

How will this intersect with imaging the system disk from the live image thingy @AvengerMoJo is working on? I guess that'll somehow slot in somewhere near SystemDisk.create()?

Yeah, that's the plan.

[codecov-commenter]

Codecov Report

Merging #757 (b41031e) into main (6ce5d64) will decrease coverage by 12.13%. The diff coverage is 38.27%.

@@             Coverage Diff             @@
##             main     #757       +/-   ##
===========================================
- Coverage   71.48%   59.35%   -12.14%     
===========================================
  Files          31       31               
  Lines        3458     3764      +306     
===========================================
- Hits         2472     2234      -238     
- Misses        986     1530      +544     

Impacted Files	Coverage Δ
src/gravel/controllers/deployment/create.py	27.15% <27.15%> (ø)
src/gravel/controllers/deployment/join.py	28.03% <28.03%> (ø)
src/gravel/controllers/ceph/orchestrator.py	52.17% <44.44%> (-2.05%)	:arrow_down:
src/gravel/controllers/deployment/mgr.py	50.00% <50.00%> (ø)
src/gravel/controllers/nodes/mgr.py	59.82% <63.88%> (-10.89%)	:arrow_down:
src/gravel/controllers/nodes/requirements.py	70.37% <66.66%> (-25.17%)	:arrow_down:
src/gravel/controllers/nodes/systemdisk.py	60.00% <66.66%> (-19.81%)	:arrow_down:
src/gravel/controllers/gstate.py	88.40% <75.00%> (-2.87%)	:arrow_down:
src/gravel/cephadm/cephadm.py	62.61% <100.00%> (+0.71%)	:arrow_up:
src/gravel/controllers/config.py	94.79% <100.00%> (-3.11%)	:arrow_down:
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6ce5d64...b41031e. Read the comment docs.