aquariumbio / aquarium

The Aquarium Lab Operating System
http://klavinslab.org/aquaverse/
MIT License
58 stars 15 forks source link

[BUG] Error Message displayed when saving new operation type #417

Closed cashmonger closed 4 years ago

cashmonger commented 4 years ago

Describe the bug When creating an operation type, Aquarium creates code objects for the protocol, documentation, preconditions, and cost model.

As part of enabling people to run tests from pfish, I added in a step to create a test file (In the operation type controller). The test file is not visible in the Aquarium interface (it’s distinct from the tests under the test tab), but it can be pulled with pfish.

This is causing an error message to appear when creating a new operation type using the interface. The operation type gets created, but an error message pops up.

As you can see from the request, there should be an entry for “test” here, but there isn’t.

To Reproduce Steps to reproduce the behavior:

  1. pull the pfish-compatibility-updates branch and run aquarium.
  2. Go to the developer page in Aquarium and hit new to create a new op type.
  3. Give the op type a name and hit save.
  4. After getting the error message, refresh the page to see that the new op type was saved.

Expected behavior There should not be an error message.

Screenshots

Error Message

ErrorMessage

Created OT

showadd

Request

request
marikoja commented 4 years ago

HAR file of request information

image

image