search

aquariumbio / aquarium

The Aquarium Lab Operating System
http://klavinslab.org/aquaverse/
MIT License
58 stars 15 forks source link

BUG: Create job button not showing on operations with manual status updates #454

Closed marikoja closed 3 years ago

marikoja commented 3 years ago

The create job button was set to hide for "on the fly" status changes. Fix: update conditional to show for all operations with status pending.

bjkeller commented 3 years ago

Thanks for finding this. Though I have a feeling having an on-the-fly operation in pending is a symptom and not the problem.

I don't believe that an on-the-fly operation type can be pending, and the system allowed the state to be manually changed to an invalid state.

bjkeller commented 3 years ago

Added issue #455

The on-the-fly check should not be necessary, but I think the implication of batching an on-the-fly operation manually could be worse than seeing operations that cannot be batched. So, I'm not going to merge this change and am closing the PR.

Managers that see this problem should verify the operation type is on-the-fly, and then change the state to 'primed' instead of 'pending'