aquariumbio / aquarium

The Aquarium Lab Operating System
http://klavinslab.org/aquaverse/
MIT License
58 stars 15 forks source link

awkward behavior when editing object types #477

Open gnomicosuw opened 3 years ago

gnomicosuw commented 3 years ago
  1. Auto-correcting behavior

NOTE: For now I am setting up the backend to auto-correct the inputs on the object types so that the behavior is consistent with the sample types. We can change this later, but it will mean changing the front-end, too (in order to process the errors when submitting the form). And for now we can simply re-use the same templates that have been created for updating a sample_type.

  1. Rows & columns
    • rows and columns only apply if the handler is “collection”, but the fields do not automatically show/hide in the GUI when you edit the handler. This is very awkward. In order to set the rows and columns you have to change the handler to a collection, save the item, then re-edit it to see the “rows” and “columns” fields (*)
    • rows and columns can be negative in the GUI. (Haha, I’d like to see that in the lab!) Interestingly, the GUI automatically sets them to [1,12] if you try to make them zero or blank, but it allows you to put in negative numbers.

() NOTE: By comparison, the “sample type” only applies if the handler is “sample_container”. Unlike the rows and columns, this field does * automatically show/hide when you make the handler to “sample_container”. (this is good!)

Here is a screenshot with negative rows, columns

Screen Shot 2020-12-02 at 7 42 27 AM
  1. handler can be blank.

Here is as screenshot of what happens with a blank handler (you get a blank option in the left-hand column)

Screen Shot 2020-12-02 at 7 41 39 AM
marikoja commented 3 years ago

Design notes per conversation with @spcoon