aquariumbio / aquarium

The Aquarium Lab Operating System
http://klavinslab.org/aquaverse/
MIT License
58 stars 15 forks source link

v2: [BUG] the { hamburger > location wizards } page does not scroll #506

Closed gnomicosuw closed 3 years ago

gnomicosuw commented 3 years ago

repro:

  1. log into aquarium as user with with admin privileges
  2. navigate to { hamburger > location wizards } page result: the page does not scroll (makes it kind of challenging to edit a location wizard that is below the fold)

(see screenshot - notice there is no scrollbar)

Screen Shot 2020-12-21 at 2 17 57 PM

note: you can add overflow-y:scroll to the < div layout="row" class="layout-row" style="overflow-y:scroll" > div in the view and get the content to scroll. It might be nicer to scroll the table contents and keep the title, but that also affects the vertical space. And since this is all probably going to change later I would do whatever is easiest. (It has been this way for a long time and as far as I know no one has complained).

Here's another screenshot with the overflow setting (notice the scrollbar)

Screen Shot 2020-12-21 at 2 32 59 PM
bjkeller commented 3 years ago

Is this problem present in either the master or staging branch?

gnomicosuw commented 3 years ago

It is in both.

bjkeller commented 3 years ago

OK, let's update this in tech-handoff

gnomicosuw commented 3 years ago

There is a whole bunch of Angular and/or React stuff on this page which I did not want to try to decipher, so I just hacked in a solution.

Note that the "Budgets" page does scroll, so there is probably some setting buried somewhere. But the hack works.

I checked it in under the branch "scroll_wizards" off of "master". I will submit a PR.

bjkeller commented 3 years ago

fixed by #507