aquariumbio / aquarium

The Aquarium Lab Operating System
http://klavinslab.org/aquaverse/
MIT License
58 stars 15 forks source link

Sort/set order of OperationTypes in Manager Tab[FEATURE] #561

Open malloc3 opened 3 years ago

malloc3 commented 3 years ago

It would be nice to be able to either sort "alphabetically", "most common use", or specify a specific custom order.

The current order feels arbitrary and confuses people. If we could order based on which Operation Types are executed first that would be really neat.

Screen Shot 2021-02-18 at 4 10 44 PM
malloc3 commented 3 years ago

@spcoon Ben told me to tag you here.

bjkeller commented 3 years ago

Not that this is good practice, but illustrating people's workarounds: there are some historic operation types with names starting with numbers representing the order in the canonical workflow.

On Fri, Feb 19, 2021 at 9:28 AM Cannon Mallory notifications@github.com wrote:

@spcoon https://github.com/spcoon Ben told me to tag you here.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aquariumbio/aquarium/issues/561#issuecomment-782220093, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJZ3PLTRPIKC4ZBZNOEZ6LS72NO5ANCNFSM4X3MWWWQ .

-- Ben Keller Aquarium Project Lead Klavins Lab Department of Electrical and Computer Engineering University of Washington bjkeller@uw.edu 206-685-6726

malloc3 commented 3 years ago

Oh smart. In this specific case that may be a great idea.

spcoon commented 3 years ago

@malloc3 - i understand the notion of "Operation Types [that] are executed first," but i do have questions.

would this specific list of operations/protocols ever change? not just in this particular grouping, "RT-qPCR," but in other groupings as well?

could other workflows be coded with the same grouping, thereby making chaos out of order? (i'm assuming the grouping assignment happens in the protocol code).

might other labs not use this grouping taxonomy approach in the same way as the biofab? note: we might want to reconsider the grouping notion altogether once we get the new design system into play.

if there's more flexibility involved, does the hierarchy of operation status (pending, waiting, etc.) give affordance as to what should be worked on first?

malloc3 commented 3 years ago

Well that is the hard part I suppose.

The specific list of operations/protocols would most certainly change. To be clear this ordering of these operation types on this page would not affect the protocol code or what the technician sees while running things.

The desired order could completely depend on the lab, workflow, or any number of arbitrary conditions.

Perhaps in stead of sorting based on operation types the list could be sorted based on operation status. E.g. Operation Types with a "Pending" status are at the top etc...

spcoon commented 3 years ago

@malloc3

here's how we're changing the interface, making pending highest priority, then errors (to make pending once again), then waiting, etc.

Screen Shot 2021-02-22 at 4 56 20 PM
malloc3 commented 3 years ago

That looks perfect! Solves the exact issue.

spcoon commented 3 years ago

@malloc3 i'm going to screenshot this moment of perfection feedback and savor it. :)