group detail page + wizard detail page

aquariumbio / aquarium

The Aquarium Lab Operating System

http://klavinslab.org/aquaverse/

MIT License

58 stars 15 forks source link

group detail page + wizard detail page #577

Closed gnomicosuw closed 3 years ago

gnomicosuw commented 3 years ago

This is the code for the group detail page (allows you to add and remove members to a group) and for the wizard detail page (for now just a skeleton).

Notes:

There are Rspec test for the group membership features.
I did not write end2end tests yet because I want to do that after we have the new test environment set up correctly and that branch merged.
Mariko, any comments you have on the React pages is welcome!

bjkeller commented 3 years ago

@gnomicosuw this says you didn't write end to end tests. I'd like to make sure we have the tests in before we merge.

gnomicosuw commented 3 years ago

Correct.

I am waiting for the docker-cypress branch so that I can write end2end tests in the "new" test environment.

I can go back and add those after v3-docker-cypress and after v3_manager get merged into v3-refactor. I will add a card to the project board.

gnomicosuw commented 3 years ago

closing this for now. will re-open a new PR after I merge the latest v3-refactor.