search

aquariumbio / aquarium

The Aquarium Lab Operating System
http://klavinslab.org/aquaverse/
MIT License
58 stars 15 forks source link

V3 manager #586

Closed marikoja closed 3 years ago

marikoja commented 3 years ago

Resolves #544 Resolves #545 Resolves #546 Resolves #543 Resolves #542 Resolves #541 Resolves #540 Resolves #582 Resolves #580 Resolves #581 Resolves #578 Resolves #579

marikoja commented 3 years ago

6. it would be good to pull all of the code related to generating the greeting into one file if possible.

Definitely possible, I had it that way initially before pulling it out incase we wanted to use the random select elsewhere or similarly add/use a different list of greetings. I'll make the change now rather than starting a new issue.

bjkeller commented 3 years ago

I've merged in v3-refactor, so nearly ready to merge. However, I'm getting end-to-end test failures.

@marikoja can you look?

marikoja commented 3 years ago

I've merged in v3-refactor, so nearly ready to merge. However, I'm getting end-to-end test failures.

@marikoja can you look?

RE: end-to-end failures, the issue I see is with the db users since this branch is not yet using the test db so we have to update both LoginDialog.spec.js and commands.js to an available user in our local dbs.