search

aquariumbio / pfish

Scripts for pulling/pushing protocols/libraries to/from Aquarium.
2 stars 1 forks source link

Fix ds store push issue #51

Closed cashmonger closed 3 years ago

cashmonger commented 3 years ago

Updates to account for non-pfish directories and files as well as incorrect definition files.

bjkeller commented 3 years ago

@cashmonger Can you resolve the merge conflicts on this? It seems like this branch may be based off an older version of master.

Also, how exactly does this resolve the DS_Store issue?

cashmonger commented 3 years ago

@cashmonger Can you resolve the merge conflicts on this? It seems like this branch may be based off an older version of master.

Done.

Also, how exactly does this resolve the DS_Store issue?

Previously, we were not checking thoroughly enough to see if files within an operation type or library directory were (1) actually directories, (2) had definition files, and (3) had correct definition files (i.e. is it for a library?). This updates our error handling to check for each of these possibilities and either ignores the files or reports an error as necessary.

In the case of something like '/wd/covid_surveillance/operation_types/_ds_store' it will now ignore "_ds_store" and not attempt to push it.