search

aquariumbio / pydent

Scripting APIs for Aquarium
http://aquariumbio.github.io/trident
MIT License
6 stars 2 forks source link

Planner optimization does not work with existing server plans [Version 0.1] #74

Closed jvrana closed 4 years ago

jvrana commented 4 years ago

Describe the bug Planner.optimize_plan() current does not work with plans pulled from the server. The Cannot wire because "{}" already has an incoming wire occurs, suggesting that wires are not being properly removed from the plan during the optimization process

To Reproduce Pull an unoptimize plan from the server and run Planner(plan).optimize_plan()

Expected behavior Plan should be optimized (identical operations with identical inputs should be merged

Additional context This points to a broader problem that Trident does not properly manage wires in plans. While the optimization works with completely new plans generated inside of Trident (before submission to an Aquarium server), optimization fails for existing plans on a server.

jvrana commented 4 years ago

This has been fixed in pull request #77