aquasecurity / cloudsploit

Cloud Security Posture Management (CSPM)
https://cloud.aquasec.com/signup
GNU General Public License v3.0
3.3k stars 668 forks source link

CloudTrail Enabled plugin false positive #139

Open dmlittle opened 6 years ago

dmlittle commented 6 years ago

Issue

We're currently getting a false positive from the CloudTrail Enabled plugin regarding not having global services enabled.

Context

We have multiple active trails in our AWS account that get funneled to different downstream services. In order to avoid getting repeated global services events from every trail, only 1 trail in our account has IncludeGlobalServiceEvents enabled. The plugin check currently breaks out of the for-loop after finding the first trail that is enabled (isLogging = true). Because of this it is not able to tell that another trail in describeTrails.data does indeed have global services enabled and misreports the configuration error.

Mav55 commented 5 years ago

Taking a look at this one.