search

aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters
Apache License 2.0
4.75k stars 585 forks source link

Rename root package #286

Closed iyehuda closed 4 years ago

iyehuda commented 4 years ago

Description

Rename src root package to kube_hunter Depends on #283.

Fixed Issues

Relates to (but does not resolve) #185 and is a prerequisite to #272

Contribution checklist

Notes

No tests were added since no new code introduced.

codecov-io commented 4 years ago

Codecov Report

Merging #286 into master will increase coverage by 0.7%. The diff coverage is 81.93%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #286     +/-   ##
=========================================
+ Coverage   58.07%   58.77%   +0.7%     
=========================================
  Files          38       39      +1     
  Lines        1994     2011     +17     
=========================================
+ Hits         1158     1182     +24     
+ Misses        836      829      -7
Impacted Files Coverage Δ
kube_hunter/core/__init__.py 100% <ø> (ø)
kube_hunter/core/events/__init__.py 100% <ø> (ø)
kube_hunter/modules/hunting/__init__.py 100% <ø> (ø)
kube_hunter/core/events/types/__init__.py 100% <ø> (ø)
kube_hunter/modules/report/__init__.py 100% <ø> (ø)
kube_hunter/modules/__init__.py 100% <ø> (ø)
kube_hunter/__init__.py 100% <ø> (ø)
kube_hunter/core/types.py 81.39% <ø> (ø)
kube_hunter/modules/discovery/__init__.py 100% <ø> (ø)
kube_hunter/modules/discovery/ports.py 75% <100%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd4d79a...e2be96d. Read the comment docs.

itaysk commented 4 years ago

just making it clear, this PR includes https://github.com/aquasecurity/kube-hunter/pull/283 right? so can we merge that one first and then rebase this one on master, so the diff will be more relevant?

iyehuda commented 4 years ago

just making it clear, this PR includes #283 right? so can we merge that one first and then rebase this one on master, so the diff will be more relevant?

Correct, I'll mention that in PR description

itaysk commented 4 years ago

actually, I'm not sure now looking at https://github.com/aquasecurity/kube-hunter/pull/286/commits and https://github.com/aquasecurity/kube-hunter/pull/283/commits they look identical, what am I missing @iYehuda ?

iyehuda commented 4 years ago

actually, I'm not sure now looking at https://github.com/aquasecurity/kube-hunter/pull/286/commits and https://github.com/aquasecurity/kube-hunter/pull/283/commits they look identical, what am I missing @iYehuda ?

The changes requested here were mistakenly pushed to #283 as well, so this one made irrelevant

iyehuda commented 4 years ago

Closing on behalf of #283