Closed mormamn closed 4 years ago
Merging #310 into master will increase coverage by
0.4%
. The diff coverage is65.57%
.
@@ Coverage Diff @@
## master #310 +/- ##
========================================
+ Coverage 59.8% 60.2% +0.4%
========================================
Files 39 41 +2
Lines 1928 1945 +17
========================================
+ Hits 1153 1171 +18
+ Misses 775 774 -1
Impacted Files | Coverage Δ | |
---|---|---|
kube_hunter/modules/report/collector.py | 89.28% <0%> (ø) |
:arrow_up: |
kube_hunter/conf/parser.py | 100% <100%> (ø) |
|
kube_hunter/conf/__init__.py | 100% <100%> (ø) |
:arrow_up: |
kube_hunter/modules/report/__init__.py | 100% <100%> (ø) |
:arrow_up: |
kube_hunter/modules/report/plain.py | 14.77% <28.57%> (-0.96%) |
:arrow_down: |
kube_hunter/modules/report/base.py | 23.52% <28.57%> (-2.19%) |
:arrow_down: |
kube_hunter/modules/report/yaml.py | 50% <50%> (-4.55%) |
:arrow_down: |
kube_hunter/modules/report/json.py | 66.66% <50%> (ø) |
:arrow_up: |
kube_hunter/modules/report/factory.py | 52.94% <52.94%> (ø) |
|
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e75c0ff...25385ae. Read the comment docs.
Hi @mormamn !
Thanks for your contribution. Notice that this PR also indirectly fixes #292.
Description
Seperated the config file and argparsing from the main file into a seprate module.
Contribution Guidelines
Please Read through the Contribution Guidelines.
Fixed Issues
Resolves #289 Resolves #292
Contribution checklist
Notes
I didn't add any functionality, so nothing needs to be added to the tests.