aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters
Apache License 2.0
4.71k stars 581 forks source link

Fix broekn reporting #313

Closed mormamn closed 4 years ago

mormamn commented 4 years ago

Description

Fixes a problem with the reporting/dispatchers. Added a test file for the functions

Contribution Guidelines

Please Read through the Contribution Guidelines.

Fixed Issues

Fixes #312

"BEFORE" and "AFTER" output

To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".

BEFORE

~ Started ~ Discovering Open Kubernetes Services...

AFTER

~ Started ~ Discovering Open Kubernetes Services...


Kube Hunter couldn't find any clusters

Contribution checklist

Notes

Please mention if you have not checked any of the above boxes.

codecov-io commented 4 years ago

Codecov Report

Merging #313 into master will decrease coverage by 0.1%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   60.25%   60.15%   -0.11%     
==========================================
  Files          41       41              
  Lines        1945     1945              
==========================================
- Hits         1172     1170       -2     
- Misses        773      775       +2
Impacted Files Coverage Δ
kube_hunter/modules/report/factory.py 100% <100%> (+47.05%) :arrow_up:
kube_hunter/modules/discovery/ports.py 76.92% <0%> (-11.54%) :arrow_down:
kube_hunter/modules/hunting/apiserver.py 69.63% <0%> (-1.99%) :arrow_down:
kube_hunter/core/events/handler.py 89.89% <0%> (-1.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8128b7...4d32fe1. Read the comment docs.