aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters
Apache License 2.0
4.71k stars 581 forks source link

Fix #127 Insecure Azure Cloud IP detection #315

Closed blrchen closed 4 years ago

blrchen commented 4 years ago

Description

Fixes #127 Insecure Azure Cloud IP detection. Replace exisitng insecure url with an SSL enabled api endpoint.

Contribution Guidelines

Please Read through the Contribution Guidelines.

Fixed Issues

Fixes #127

Fixes #(issue)

"BEFORE" and "AFTER" output

To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".

BEFORE

Any Terminal Output Before Changes.

AFTER

Any Terminal Output Before Changes.

Contribution checklist

Notes

I verified the new api endpoint is secured by checking the certification when invoking https://api.azurespeed.com/api/region?ipOrUrl=www.azure.com

codecov-io commented 4 years ago

Codecov Report

Merging #315 into master will decrease coverage by 0.25%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #315      +/-   ##
=========================================
- Coverage   60.46%   60.2%   -0.26%     
=========================================
  Files          41      41              
  Lines        1945    1945              
=========================================
- Hits         1176    1171       -5     
- Misses        769     774       +5
Impacted Files Coverage Δ
kube_hunter/modules/hunting/apiserver.py 69.63% <0%> (-1.99%) :arrow_down:
kube_hunter/core/events/handler.py 90.9% <0%> (+1.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e6f2d8...8bde02b. Read the comment docs.