Closed mormamn closed 4 years ago
Merging #318 into master will decrease coverage by
0.8%
. The diff coverage is38.77%
.
@@ Coverage Diff @@
## master #318 +/- ##
=========================================
- Coverage 60.11% 59.3% -0.81%
=========================================
Files 41 41
Lines 1963 1939 -24
=========================================
- Hits 1180 1150 -30
- Misses 783 789 +6
Impacted Files | Coverage Δ | |
---|---|---|
kube_hunter/modules/discovery/proxy.py | 50% <ø> (ø) |
:arrow_up: |
kube_hunter/modules/hunting/apiserver.py | 69.63% <ø> (-1.99%) |
:arrow_down: |
kube_hunter/modules/report/collector.py | 84.61% <ø> (-4.68%) |
:arrow_down: |
kube_hunter/modules/hunting/proxy.py | 49.12% <ø> (ø) |
:arrow_up: |
kube_hunter/modules/hunting/secrets.py | 55.55% <ø> (-3.07%) |
:arrow_down: |
kube_hunter/modules/discovery/kubectl.py | 46.42% <ø> (-1.85%) |
:arrow_down: |
kube_hunter/modules/report/factory.py | 100% <ø> (ø) |
:arrow_up: |
kube_hunter/modules/hunting/dns.py | 40.47% <ø> (ø) |
:arrow_up: |
kube_hunter/modules/report/dispatchers.py | 50% <ø> (+2.94%) |
:arrow_up: |
kube_hunter/modules/hunting/aks.py | 38.46% <ø> (ø) |
:arrow_up: |
... and 18 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6c34a62...211ca32. Read the comment docs.
Description
Now we are using python logging best practices, each module.py has it's own logger with logger.getLogger(), formatting is also a lot better now.
Contribution Guidelines
Please Read through the Contribution Guidelines.
Fixed Issues
Resolves #308
"BEFORE" and "AFTER" output
BEFORE
Example log output:
AFTER
Example log output:
Contribution checklist
Notes
Logging is ignored by setup.cfg so no need to test it