Closed jnschaeffer closed 4 years ago
Merging #323 into master will increase coverage by
0.34%
. The diff coverage is94.59%
.
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
+ Coverage 60.16% 60.50% +0.34%
==========================================
Files 41 42 +1
Lines 1968 1985 +17
==========================================
+ Hits 1184 1201 +17
Misses 784 784
Impacted Files | Coverage Δ | |
---|---|---|
kube_hunter/conf/parser.py | 95.23% <80.00%> (-4.77%) |
:arrow_down: |
kube_hunter/modules/discovery/hosts.py | 79.83% <95.23%> (+2.44%) |
:arrow_up: |
kube_hunter/conf/__init__.py | 100.00% <100.00%> (ø) |
|
kube_hunter/conf/logging.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 124a51d...901110d. Read the comment docs.
Just saw this got updated! Thanks for taking this on; sorry I forgot to respond to the comments 😅
Description
This updates
__init__.py
in theconf
package to disable logging if--log
is set tonone
.Contribution Guidelines
Please Read through the Contribution Guidelines.
Fixed Issues
Fixes #322
"BEFORE" and "AFTER" output
To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".
BEFORE
AFTER
Contribution checklist
Notes
I'm not sure how, or if, the
__init__.py
for this package can be tested.