Closed shellw closed 3 years ago
Merging #327 into master will decrease coverage by
1.51%
. The diff coverage is9.83%
.
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
- Coverage 59.56% 58.05% -1.52%
==========================================
Files 41 42 +1
Lines 1939 2000 +61
==========================================
+ Hits 1155 1161 +6
- Misses 784 839 +55
Impacted Files | Coverage Δ | |
---|---|---|
kube_hunter/conf/parser.py | 100% <ø> (ø) |
:arrow_up: |
kube_hunter/modules/report/factory.py | 100% <100%> (ø) |
:arrow_up: |
kube_hunter/modules/report/ndjson.py | 8.33% <8.33%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e7585f4...b640ce4. Read the comment docs.
Hi @shellw !
Thanks for your contribution. Please fix formatting issues (using flake8) on your new added code.
Hi @shellw We would love to see this get implemented. Can you make the proposed adjustments so we could merge?
Closing due to inactivity.
Description
This PR adds an ndjson reporting option. This allows the results to be flattened into individual json dictionaries (for each unique combination of nodes, services, and vulnerabilities). Each json dictionary will be delimited by a new line in the output. Having this reporting option will make aggregating data and querying logs easier.
Contribution Guidelines
Please Read through the Contribution Guidelines.
Fixed Issues
Please mention any issues fixed in the PR by referencing it properly in the commit message. Resolves #326
"BEFORE" and "AFTER" output
To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".
BEFORE
Any Terminal Output Before Changes.
AFTER
Note that data here just reflects sample data with placeholder numbers:
Contribution checklist
Notes
Please mention if you have not checked any of the above boxes.