aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters
Apache License 2.0
4.71k stars 581 forks source link

Linting Standards #330

Closed iyehuda closed 4 years ago

iyehuda commented 4 years ago

Description

Contribution Guidelines

Please Read through the Contribution Guidelines.

Fixed Issues

Fixes #320

"BEFORE" and "AFTER" output

BEFORE

Ugly code.

AFTER

Less ugly code.

Contribution checklist

codecov-io commented 4 years ago

Codecov Report

Merging #330 into master will increase coverage by 0.56%. The diff coverage is 38.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   59.59%   60.16%   +0.56%     
==========================================
  Files          41       41              
  Lines        1943     1968      +25     
==========================================
+ Hits         1158     1184      +26     
+ Misses        785      784       -1     
Impacted Files Coverage Δ
kube_hunter/core/events/handler.py 90.90% <ø> (+1.01%) :arrow_up:
kube_hunter/modules/discovery/dashboard.py 57.69% <ø> (+1.69%) :arrow_up:
kube_hunter/modules/discovery/etcd.py 75.00% <ø> (ø)
kube_hunter/modules/discovery/kubectl.py 46.42% <0.00%> (ø)
kube_hunter/modules/discovery/ports.py 77.77% <ø> (+0.85%) :arrow_up:
kube_hunter/modules/discovery/proxy.py 51.85% <ø> (+1.85%) :arrow_up:
kube_hunter/modules/hunting/aks.py 38.46% <0.00%> (ø)
kube_hunter/modules/hunting/arp.py 50.00% <0.00%> (ø)
kube_hunter/modules/hunting/capabilities.py 59.09% <0.00%> (ø)
kube_hunter/modules/hunting/certificates.py 67.85% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ddf321...c599f77. Read the comment docs.