search

aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters
Apache License 2.0
4.71k stars 581 forks source link

Dashboard hunter not working #337

Closed mormamn closed 4 years ago

mormamn commented 4 years ago

solves #336, just a typo.

Description

There was a typo in dashboard.py calling network_timwout instead of network_timeout

Contribution Guidelines

Please Read through the Contribution Guidelines.

Fixed Issues

Fixes #336

"BEFORE" and "AFTER" output

To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".

BEFORE

Dashboard hunter not-working

AFTER

Dashboard hunter working

Contribution checklist

Notes

codecov-io commented 4 years ago

Codecov Report

Merging #337 into master will increase coverage by 0.20%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
+ Coverage   60.20%   60.40%   +0.20%     
==========================================
  Files          41       41              
  Lines        1970     1970              
==========================================
+ Hits         1186     1190       +4     
+ Misses        784      780       -4
Impacted Files Coverage Δ
kube_hunter/modules/hunting/dashboard.py 86.36% <100.00%> (+18.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14d73e2...87219b5. Read the comment docs.