aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters

Apache License 2.0

4.7k stars 581 forks source link

Fix: Removed an unnecessary f-string causing linting problem #355

Closed danielsagi closed 4 years ago

danielsagi commented 4 years ago

Description

An unnecessary f-string appeared in an info logging message, which caused CI to fail on linting

Fixed Issues

Removed the f-string, changed to normal string. no issue regarding this. related #354

"BEFORE" and "AFTER" output

BEFORE

$ make lint-check
flake8
./kube_hunter/core/events/types.py:151:25: F541 f-string is missing placeholders
Makefile:29: recipe for target 'lint-check' failed
make: *** [lint-check] Error 1

AFTER

No Errors

Contribution checklist

[x] I have read the Contributing Guidelines.
[ ] The commits refer to an active issue in the repository.
[ ] I have added automated testing to cover this case.

Notes

codecov[bot] commented 4 years ago

Codecov Report

Merging #355 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   58.11%   58.11%           
=======================================
  Files          40       40           
  Lines        2039     2039           
=======================================
  Hits         1185     1185           
  Misses        854      854

Impacted Files	Coverage Δ
kube_hunter/core/events/types.py	`82.60% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4484ad7...1b924c7. Read the comment docs.