aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters
Apache License 2.0
4.7k stars 581 forks source link

update gitignore #371

Closed itaysk closed 3 years ago

itaysk commented 3 years ago

Fixed Issues

add pip-wheel-metadata to the .gitignore

Contribution checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #371 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   62.77%   62.77%           
=======================================
  Files          42       42           
  Lines        2281     2281           
=======================================
  Hits         1432     1432           
  Misses        849      849           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 24b5a70...521d859. Read the comment docs.

itaysk commented 3 years ago

How did you get that file?

I just did make deps and make dev-deps

I saw that this was fixed in pip 20.2.2 which will use a temp dir instead, but I thought it would be better to add it to .getignore anyway

evrardjp commented 3 years ago

Yes indeed, I am not against that :)

I just thought it was worth a message in the commit message to explain the full context.