search

aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters
Apache License 2.0
4.7k stars 581 forks source link

Increase evidence field length in plain report #385

Closed reegnz closed 3 years ago

reegnz commented 3 years ago

Given that the Description tends to go over 100 characters as well, it seems appropriate to loosen the restriction of the evidence field.

Fixes #111

Description

Please include a summary of the change and which issue is fixed. Also include relevant motivation and context. List any dependencies that are required for this change.

Contribution Guidelines

Please Read through the Contribution Guidelines.

Fixed Issues

Please mention any issues fixed in the PR by referencing it properly in the commit message. As per the convention, use appropriate keywords such as fixes, closes, resolves to automatically refer the issue. Please consult official github documentation for details.

Fixes #(issue)

"BEFORE" and "AFTER" output

To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".

BEFORE

Any Terminal Output Before Changes.

AFTER

Any Terminal Output Before Changes.

Contribution checklist

Notes

Please mention if you have not checked any of the above boxes.

codecov[bot] commented 3 years ago

Codecov Report

Merging #385 into master will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
+ Coverage   62.73%   62.77%   +0.04%     
==========================================
  Files          42       42              
  Lines        2281     2281              
==========================================
+ Hits         1431     1432       +1     
+ Misses        850      849       -1
Impacted Files Coverage Δ
kube_hunter/modules/report/plain.py 13.48% <100.00%> (ø)
kube_hunter/core/events/handler.py 91.08% <0.00%> (+0.99%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9cadc0e...654448c. Read the comment docs.