aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters
Apache License 2.0
4.7k stars 581 forks source link

Typo Updated for kube-hunter docs to sound more meaningful #390

Closed echobash closed 3 years ago

echobash commented 3 years ago

Description

Please include a summary of the change and which issue is fixed. Also include relevant motivation and context. List any dependencies that are required for this change.

Contribution Guidelines

Please Read through the Contribution Guidelines.

Fixed Issues

Please mention any issues fixed in the PR by referencing it properly in the commit message. As per the convention, use appropriate keywords such as fixes, closes, resolves to automatically refer the issue. Please consult official github documentation for details.

Fixes #(issue)

"BEFORE" and "AFTER" output

To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".

BEFORE

Any Terminal Output Before Changes.

AFTER

Any Terminal Output Before Changes.

Contribution checklist

Notes

Please mention if you have not checked any of the above boxes.

codecov[bot] commented 3 years ago

Codecov Report

Merging #390 into master will decrease coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
- Coverage   62.77%   62.73%   -0.05%     
==========================================
  Files          42       42              
  Lines        2281     2281              
==========================================
- Hits         1432     1431       -1     
- Misses        849      850       +1     
Impacted Files Coverage Δ
kube_hunter/core/events/handler.py 90.09% <0.00%> (-1.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3950a1c...c2aec47. Read the comment docs.

danielsagi commented 3 years ago

Hi, Thanks for your time in making this contribution. However this adds no value to the README, so we will not merge it. Don't let this discourage you though, I'm sure that with some time and motivation you can find something you can fix/add value with.