search

aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters
Apache License 2.0
4.7k stars 581 forks source link

Update certificates.py #398

Closed RDxR10 closed 3 years ago

RDxR10 commented 3 years ago

Regex expression update for email

Description

Please include a summary of the change and which issue is fixed. Also include relevant motivation and context. List any dependencies that are required for this change. Dependencies : N/A

Contribution Guidelines

Please Read through the Contribution Guidelines.

Fixed Issues

Please mention any issues fixed in the PR by referencing it properly in the commit message. As per the convention, use appropriate keywords such as fixes, closes, resolves to automatically refer the issue. Please consult official github documentation for details.

Fixes #(issue)

"BEFORE" and "AFTER" output

To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".

BEFORE

Any Terminal Output Before Changes.

AFTER

Any Terminal Output Before Changes.

Contribution checklist

Notes

Please mention if you have not checked any of the above boxes.

danielsagi commented 3 years ago

Hi @RDxR10 We want to merge, just fix the linting issue: 

flake8
./kube_hunter/modules/hunting/certificates.py:16:175: B950 line too long (174 > 120 characters)
Makefile:29: recipe for target 'lint-check' failed
codecov[bot] commented 3 years ago

Codecov Report

Merging #398 (bbf2b9d) into master (f5e8b14) will increase coverage by 0.26%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
+ Coverage   63.56%   63.82%   +0.26%     
==========================================
  Files          42       42              
  Lines        2289     2289              
==========================================
+ Hits         1455     1461       +6     
+ Misses        834      828       -6
Impacted Files Coverage Δ
kube_hunter/modules/hunting/certificates.py 93.33% <100.00%> (ø)
kube_hunter/modules/hunting/apiserver.py 72.25% <0.00%> (+1.93%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5e8b14...bbf2b9d. Read the comment docs.