Closed hugovk closed 3 years ago
Merging #399 (63c9b60) into master (05094a9) will increase coverage by
0.04%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 63.52% 63.56% +0.04%
==========================================
Files 42 42
Lines 2289 2289
==========================================
+ Hits 1454 1455 +1
+ Misses 835 834 -1
Impacted Files | Coverage Δ | |
---|---|---|
kube_hunter/core/events/handler.py | 91.08% <0.00%> (+0.99%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 05094a9...63c9b60. Read the comment docs.
Description
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context. List any dependencies that are required for this change.
Run tests using GitHub Actions:
It has 20 parallel runners compared to officially 5 on Travis, but nowadays often 4 or less
Easy to test on Ubuntu 16.04, 18.04 and 20.04
We can put lint in a separate build job, so if something fails it's obvious right away if the problem is linting or the tests, without clicking through and opening and scrolling the build logs
pre-commit already does the lint check, it's simple and clean to use that on the CI too. A benefit is it uses the same pinned linter versions as local pre-commit use.
Contribution Guidelines
Please Read through the Contribution Guidelines.
Fixed Issues
Please mention any issues fixed in the PR by referencing it properly in the commit message. As per the convention, use appropriate keywords such as
fixes
,closes
,resolves
to automatically refer the issue. Please consult official github documentation for details.Fixes https://github.com/aquasecurity/kube-hunter/issues/395
"BEFORE" and "AFTER" output
To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".
BEFORE
Any Terminal Output Before Changes.
n/a
AFTER
Any Terminal Output Before Changes.
n/a
Sample runs:
Contribution checklist
Notes
Please mention if you have not checked any of the above boxes.