aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters
Apache License 2.0
4.66k stars 579 forks source link

Fix lint comments #414

Closed danielsagi closed 3 years ago

danielsagi commented 3 years ago

Description

Commented out test_port_forward function in kubelet hunting. I created an issue #413 that concerns this, but we can't have a non complete function with flake8 running.

This is regarding moving our tests to github actions #399 , the flake8 in the test environment complains about this function.

Contribution checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #414 (3ac4ac9) into master (14ca1b8) will increase coverage by 0.03%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   63.48%   63.52%   +0.03%     
==========================================
  Files          42       42              
  Lines        2292     2289       -3     
==========================================
- Hits         1455     1454       -1     
+ Misses        837      835       -2     
Impacted Files Coverage Δ
kube_hunter/modules/hunting/kubelet.py 60.00% <0.00%> (+0.36%) :arrow_up:
kube_hunter/core/events/handler.py 90.09% <0.00%> (-1.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8acedf2...3ac4ac9. Read the comment docs.