search

aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters
Apache License 2.0
4.66k stars 579 forks source link

Update README.md #430

Closed franciosi closed 3 years ago

franciosi commented 3 years ago

Adding simple numbers to make the install documentation easier

codecov[bot] commented 3 years ago

Codecov Report

Merging #430 (c3658e4) into main (cdbc3dc) will increase coverage by 0.26%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   63.41%   63.67%   +0.26%     
==========================================
  Files          42       42              
  Lines        2296     2296              
==========================================
+ Hits         1456     1462       +6     
+ Misses        840      834       -6
Impacted Files Coverage Δ
kube_hunter/modules/hunting/apiserver.py 72.34% <0.00%> (+1.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cdbc3dc...c3658e4. Read the comment docs.

danielsagi commented 3 years ago

Hi @franciosi Thanks for your contribution! However, I don't see how adding numbers in the readme makes difference in understanding it better.. I encourage you to add a contribution in the code :)

franciosi commented 3 years ago

Hi @danielsagi

OK, it was just a simple improve. This is how normal we do with documentation, like https://www.freebsd.org/doc/handbook/. About code, yes, I plan to do it, as soon as I have more time. Very much involved with FOSS documentation and translations for now.

Congratulations for kube-hunter, it's an amazing project!!