aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters
Apache License 2.0
4.65k stars 578 forks source link

make publish the same as in kube-bench #508

Closed rhtenhove closed 2 years ago

rhtenhove commented 2 years ago

Description

See #507 for a description. This still needs some checking by admins to verify if things will now work as intended, as I don't know the secrets nor know of any custom setups in the docker publish pipeline used by kube-bench.

Contribution Guidelines

Please Read through the Contribution Guidelines.

Fixed Issues

proposes a potential fix for #507

Contribution checklist

codecov[bot] commented 2 years ago

Codecov Report

Merging #508 (65a2c6a) into main (c442172) will increase coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   65.51%   65.55%   +0.04%     
==========================================
  Files          44       44              
  Lines        2456     2456              
==========================================
+ Hits         1609     1610       +1     
+ Misses        847      846       -1     
Impacted Files Coverage Δ
kube_hunter/core/events/event_handler.py 87.27% <0.00%> (+0.60%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c442172...65a2c6a. Read the comment docs.

danielsagi commented 2 years ago

Hi, like I commented on the issue, the action didnt run with the new updates yet. lets wait to the next release :)