Open danielsagi opened 2 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Merging #510 (3df7ea8) into main (a578726) will increase coverage by
1.31%
. The diff coverage is62.50%
.
@@ Coverage Diff @@
## main #510 +/- ##
==========================================
+ Coverage 65.26% 66.58% +1.31%
==========================================
Files 44 46 +2
Lines 2456 2523 +67
==========================================
+ Hits 1603 1680 +77
+ Misses 853 843 -10
Impacted Files | Coverage Δ | |
---|---|---|
kube_hunter/core/events/types.py | 83.18% <ø> (+0.37%) |
:arrow_up: |
kube_hunter/modules/hunting/aks.py | 56.06% <37.50%> (+1.64%) |
:arrow_up: |
kube_hunter/modules/discovery/cloud/aws.py | 40.90% <40.90%> (ø) |
|
kube_hunter/modules/discovery/hosts.py | 72.89% <50.00%> (+18.88%) |
:arrow_up: |
kube_hunter/modules/discovery/cloud/azure.py | 90.14% <90.14%> (ø) |
|
kube_hunter/conf/__init__.py | 97.05% <100.00%> (ø) |
|
kube_hunter/conf/parser.py | 81.81% <100.00%> (ø) |
|
kube_hunter/core/types/components.py | 100.00% <100.00%> (ø) |
|
kube_hunter/modules/discovery/__init__.py | 100.00% <100.00%> (ø) |
|
kube_hunter/core/events/event_handler.py | 87.27% <0.00%> (+0.60%) |
:arrow_up: |
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a578726...3df7ea8. Read the comment docs.
Description
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context. List any dependencies that are required for this change.
Contribution Guidelines
Please Read through the Contribution Guidelines.
Fixed Issues
Please mention any issues fixed in the PR by referencing it properly in the commit message. As per the convention, use appropriate keywords such as
fixes
,closes
,resolves
to automatically refer the issue. Please consult official github documentation for details.Fixes #(issue)
"BEFORE" and "AFTER" output
To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".
BEFORE
Any Terminal Output Before Changes.
AFTER
Any Terminal Output Before Changes.
Contribution checklist
Notes
Please mention if you have not checked any of the above boxes.