aquasecurity / kube-hunter

Hunt for security weaknesses in Kubernetes clusters
Apache License 2.0
4.77k stars 587 forks source link

Removing netifaces due to lack of maintainer #519

Closed danielsagi closed 2 years ago

danielsagi commented 2 years ago

Description

This issue arose due to the lack of maintainer for the netifaces package. in this PR we remove it's usage completely.

now using the pyroute2 package for linux and a powershell snippet for windows, as suggested by @newtondev in #516 . Thanks! the library is dual licensed so we can use it under the Apache 2 license.

the only downside for this is the necessity for the time being to remove support for running in pod mode in a windows host. Anyway we didn't came across a real need for this in production environments. so let us know if u require this support in the future.

Fixed Issues

fixes #516

Contribution checklist

Notes

Please mention if you have not checked any of the above boxes.

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

06kellyjac commented 2 years ago

Thanks :)