search

aquasecurity / manifesto

Use Manifesto to store and query metadata for container images.
Apache License 2.0
163 stars 15 forks source link

Show how manifesto affects repository #2

Closed garethr closed 6 years ago

garethr commented 7 years ago

I think it would be worthwhile including a screen shot and some details about what users should expect in Hub when they add a manifest.

For example, seeing the _manifesto_lumogon and _manifesto images wasn't unexpected but could be for some users. And setting expectations is useful I think. ehg. https://hub.docker.com/r/puppet/puppet-agent/tags/

lizrice commented 7 years ago

I've added a note about this, but leaving open to make sure we're clear about the additional image tag once we release the version that stores directly to blobs

viccab commented 7 years ago

I've managed to build the manifesto app after some tweaking with the GOPATH. Question, will it work on any docker image ? I'm getting "Couldn't get digest: digest not found in []" when I run the manifesto put on the image. I then see another image created with the _manifesto_something tag. Can it be updated to accept image ID also? I am unable to query the manifesto status of the newly created image with the _manifesto_something tag.

lizrice commented 7 years ago

Hi @viccab, it will only work on image repos that you have write access to. See #5 - does that help? If not, please do raise another issue - it would be helpful if you could copy in the output you get from the manifesto commands and from running docker images. Thanks!

viccab commented 7 years ago

Thanks, Liz! I got it to work already.

viccab commented 7 years ago

I agree with @garethr. Are you going to add also some cleanup of _manifesto_lumogon and _manifesto images in the local repo? manifesto appears to query the Hub registry for the metadata and does not need the 2 manifesto images.

lizrice commented 7 years ago

Yes, the intention is to store the metadata directly in blobs rather than in their own image (see the notes at the end of the README) On Wed, 26 Jul 2017 at 17:38, viccab notifications@github.com wrote:

I agree with @garethr https://github.com/garethr. Are you going to add also some cleanup of _manifesto_lumogon and _manifesto images in the local repo? manifesto appears to query the Hub registry for the metadata and does not need the 2 manifesto images.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aquasecurity/manifesto/issues/2#issuecomment-318110884, or mute the thread https://github.com/notifications/unsubscribe-auth/AAb_eNEw0NyjbBCp8mUsToWAmpJhjNt9ks5sR2uagaJpZM4OVxc9 .

-- Liz Rice lizrice.com | +44 (0) 780 126 1145 | skype lizrice

lizrice commented 6 years ago

I think this is sorted now we have blob storage, and we document the _manifesto image tag. Please shout if you think it needs more clarity.