Update component usage and add action pattern

aquasecurity / starboard-octant-plugin

Octant plugin for viewing Starboard security information

https://github.com/aquasecurity/starboard

Apache License 2.0

57 stars 12 forks source link

Update component usage and add action pattern #85

Open GuessWhoSamFoo opened 3 years ago

GuessWhoSamFoo commented 3 years ago

This PR introduces the following changes:

A proof of concept for using buttons to trigger an action. This is done by creating a wrapper around the respective starboard command.
Refactoring old markdown components to directly use links and icons
Increase visibility to vulnerabilities by changing icon status color (in this case, only critical) and at-a-glance view from a signpost
Show how to create multiple tabs from a single plugin.

GuessWhoSamFoo commented 3 years ago

Let me know if the proposed fixes are acceptable and I can make another patch. Otherwise we can break up this PR into items that are considered merge-able while fixing upstream octant

danielpacak commented 3 years ago

Let me know if the proposed fixes are acceptable and I can make another patch. Otherwise we can break up this PR into items that are considered merge-able while fixing upstream octant

@GuessWhoSamFoo Let's wrap up this PR according to your suggestions and merge it. Once you fix upstream Octant we can update this plugin to take advantage of such enhancements.

CLAassistant commented 3 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Sam Foo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}