Rewrite action to an composite action

aquasecurity / tfsec-action

Vanilla GitHub action to run tfsec

MIT License

51 stars 28 forks source link

Rewrite action to an composite action #11

Closed jkroepke closed 1 year ago

jkroepke commented 1 year ago

Fixes #6, Fixes #10, Fixes #13

Benefits of this PR:

Save time by avoiding building docker images.
Remove dependency against docker daemon. In conclusion, this actions runs a dockerized self-hosted runners.
Cross OS compatibility (Tested on Windows, Mac and Linux)
Reduce maintenance, e.g. bump alpine version in docker file
It prevents any API rate-limited issues by not using the API of GitHub.
Adding tests through GitHub actions

jkroepke commented 1 year ago

@giorod3 if merged, I can do the same PR on the pr commter repository.

jkroepke commented 1 year ago

@giorod3 @nkuik Is there any chance to get this merged?

nkuik commented 1 year ago

@giorod3 @nkuik Is there any chance to get this merged?

I don't have write access on this repo, apologies. It was @giorod3 that merged my PR last time.

pkobielak commented 1 year ago

Any info when this will be merged?

For anyone looking for fix for: https://github.com/aquasecurity/tfsec/issues/1935

I'm happily using this to fix it for github actions:

     - name: Run tfsec
        uses: jkroepke/tfsec-action@patch-1
        with:
          version: "v1.28.0"
          additional_args: --exclude-downloaded-modules

jkroepke commented 1 year ago

Seems like tfsec is getting deprecated. may no chance to getting this merged.

https://github.com/aquasecurity/tfsec/issues/2047#issuecomment-1519648410

jkroepke commented 1 year ago

Closed, see: https://github.com/aquasecurity/tfsec/discussions/1994