aquasecurity / tfsec-action

Vanilla GitHub action to run tfsec
MIT License
51 stars 28 forks source link

feat: Allow GitHub token to avoid GitHub API rate limiting #9

Closed nkuik closed 1 year ago

nkuik commented 1 year ago

This should solve the GitHub API rate limiting issue I created: https://github.com/aquasecurity/tfsec-action/issues/8

Heavily inspired (to the point of almost copying) by: https://github.com/aquasecurity/tfsec-pr-commenter-action/pull/82

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

ruial commented 1 year ago

Hi all, any update on this? Hitting rate limits quite a lot lately.

ACN-kck commented 1 year ago

@nkuik I guess you have to agree to the Contributor License Agreement (see GitHub Action)

nkuik commented 1 year ago

I needed to get some things cleared before I signed the CLA, and I have now signed it, so this should be ready to go.

nkuik commented 1 year ago

@andrea-defraia @roee-landesman Is there anything additional I can do to help this PR get merged?

roee-landesman commented 1 year ago

LGTM, need approver for merging

nkuik commented 1 year ago

@owenrumney Apologies for tagging you directly, but since your commit's the last one for this repo, I was wondering if we might get some help to get this changed merged? It seems there are a decent number of people experiencing the rate-limiting issue

owenrumney commented 1 year ago

Hi, I'm afraid I'm no longer involved in tfsec for aqua - suggest raising it in the tfsec slack channel.

Good luck

ferhatys commented 1 year ago

@roee-landesman @andrea-defraia can we get this PR merged? We're having rate limiting issues.

nkuik commented 1 year ago

@roee-landesman @andrea-defraia can we get this PR merged? We're having rate limiting issues.

Neither of the approvers have merge rights. The PR has been posted in the Aqua Security by multiple people (as suggested in one of the earlier comments), but no one has responded 😞

giorod3 commented 1 year ago

hi @nkuik, thank you for the contribution! I will be taking over this repo, please give me some time to review the code .