search

aquasecurity / trivy-azure-pipelines-task

An Azure Pipelines Task for trivy
https://marketplace.visualstudio.com/items?itemName=AquaSecurityOfficial.trivy-official
MIT License
47 stars 34 forks source link

Update task.json #33

Closed giorod3 closed 1 year ago

giorod3 commented 1 year ago

This fixes the issue #32 where cmd severity is overriding the env severity when no cmd severity is provided. This happens because of the default that can be blank.

giorod3 commented 1 year ago

@markwooff Can you please review this PR as it makes changes to code you had contributed. I want to ensure this fix will still work for your use case. Keep in mind that if no severity is provided to Trivy, it defaults to all severities.

giorod3 commented 1 year ago

@cjbush this PR fixes your issue, I will merge it once it is reviewed

cjbush commented 1 year ago

Much appreciated @giorod3!

markwooff commented 1 year ago

Looks good to me. Good idea to let the default value be blank for those cases where a user wants an empty severity level.