search

aquasecurity / trivy-vscode-extension

A VS Code Extension for Trivy
https://marketplace.visualstudio.com/items?itemName=AquaSecurityOfficial.trivy-vulnerability-scanner
Apache License 2.0
116 stars 21 forks source link

first commit was pushed related to update the trivy version #52

Open calsoftfaizal813 opened 5 days ago

calsoftfaizal813 commented 5 days ago

I ran trivy scanning for the test project "Trivy-ci-test" and updated the trivy version.

there are three file changes included in this commit: extension.ts trivy_wrapper.ts package-lock.json

here are the screenshots of the scanning results: image

CLAassistant commented 5 days ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

simar7 commented 1 day ago

hi @calsoftfaizal813 - thanks for the PR. A few comments:

  1. Please format commit messages as per this convention https://www.conventionalcommits.org/en/v1.0.0/#summary
  2. Please sign the CLA with your GitHub account, the instructions are in the comment here
  3. Looks like the tests are failing, we'd probably have to update the assertion as the newer version of Trivy detects more problems than before. image
calsoftfaizal813 commented 1 day ago

hi @calsoftfaizal813 - thanks for the PR. A few comments:

  1. Please format commit messages as per this convention https://www.conventionalcommits.org/en/v1.0.0/#summary
  2. Please sign the CLA with your GitHub account, the instructions are in the comment here
  3. Looks like the tests are failing, we'd probably have to update the assertion as the newer version of Trivy detects more problems than before.
image

Hi Simarpreet Singh. like this above screenshot, Could you please help me with this running test case locally on my vscode so I can test my recently made changes and update the PR

simar7 commented 17 hours ago

Could you please help me with this running test case locally on my vscode so I can test my recently made changes and update the PR

The project already contains two test targets, one is for running the extension and the other for tests. https://github.com/aquasecurity/trivy-vscode-extension/blob/master/src/test/suite/extension.test.ts

You can read more on how to run the test target here: https://code.visualstudio.com/api/working-with-extensions/testing-extension