aquasecurity / trivy

Find vulnerabilities, misconfigurations, secrets, SBOM in containers, Kubernetes, code repositories, clouds and more
https://aquasecurity.github.io/trivy
Apache License 2.0
22.14k stars 2.18k forks source link

chore: use `!` for breaking changes #6994

Closed knqyf263 closed 2 weeks ago

knqyf263 commented 2 weeks ago

Description

For clarity, we added the type BREAKING to the existing type of Conventional Commits, but Release Please recognizes only breaking changes indicated by the !.

feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.

https://github.com/googleapis/release-please/blob/ace2bd5dc778f83c33ad5dee6807db5d0afdba36/README.md?plain=1#L52-L53

Now, it's better to follow Conventional Commits.

Checklist

simar7 commented 2 weeks ago

and will result in a SemVer major.

Just to clarify, will every breaking change will be a major version bump?

knqyf263 commented 2 weeks ago

Just to clarify, will every breaking change will be a major version bump?

I believe not. We set "bump-minor-pre-major": true. https://github.com/aquasecurity/trivy/blob/648ead9553eb2cbeac90e3ef7330a70c352255ac/release-please-config.json#L5

// BREAKING CHANGE only bumps semver minor if version < 1.0.0 // absence defaults to false

https://github.com/googleapis/release-please/blob/ace2bd5dc778f83c33ad5dee6807db5d0afdba36/docs/manifest-releaser.md