perf(debian): split fs walk between info and status files - Githubissues

aquasecurity / trivy

Find vulnerabilities, misconfigurations, secrets, SBOM in containers, Kubernetes, code repositories, clouds and more

https://aquasecurity.github.io/trivy

Apache License 2.0

22.1k stars 2.18k forks source link

perf(debian): split fs walk between info and status files #7082

Open paulcacheux opened 3 days ago

paulcacheux commented 3 days ago

Description

This PR improves the dpkg analyzer by ensuring only interesting files are opened and scanned, and not all files in the FS. To do this, this PR splits the walk dir operation into:

one walk in var/lib/dpkg/info/*.list for the info files
a single read for var/lib/dpkg/status
one walk in var/lib/dpkg/status.d/* for the status files

Related issues

Closes https://github.com/aquasecurity/trivy/discussions/7081

Related PRs

[ ] #XXX
[ ] #YYY

Remove this section if you don't have related PRs.

Checklist

[x] I've read the guidelines for contributing to this repository.
[x] I've followed the conventions in the PR title.
[ ] I've added tests that prove my fix is effective or that my feature works.
[ ] I've updated the documentation with the relevant information (if needed).
[ ] I've added usage information (if the PR introduces new options)
[ ] I've included a "before" and "after" example to the description (if the PR is a user interface change).