aquasecurity / trivy

Find vulnerabilities, misconfigurations, secrets, SBOM in containers, Kubernetes, code repositories, clouds and more
https://aquasecurity.github.io/trivy
Apache License 2.0
23.79k stars 2.34k forks source link

refactor(misconf): Remove unused options #7896

Open simar7 opened 1 week ago

simar7 commented 1 week ago

Description

These options aren't often used due to reasons described in the disucussion and can be deprecated.

Related issues

Related discussion

Checklist

nikpivkin commented 2 days ago

@simar7 Does that mean we should now only support deny rules? https://github.com/aquasecurity/trivy/blob/main/pkg/iac/rego/scanner.go#L388-L395

nikpivkin commented 2 days ago

combined is also mentioned in the documentation.

simar7 commented 2 days ago

@simar7 Does that mean we should now only support deny rules? https://github.com/aquasecurity/trivy/blob/main/pkg/iac/rego/scanner.go#L388-L395

Yes, there's even a comment about this https://github.com/aquasecurity/trivy/blame/797b36fbad90b8e7f04e16e2cf08d6bdc0255ac7/pkg/iac/rego/scanner.go#L387

Actually I just realized we didn't issue an announcement for this change. I will prepare that first.

Discussion here: https://github.com/aquasecurity/trivy/discussions/7961