TFSEC extension seems to fight hashicorp official for comment toggle

drewmullen commented 2 years ago

Describe the bug

Upon VSCode restart I cannot toggle comments (cmd + /) unless i disable tfsec then reenable it.

Desktop (please complete the following information):

OS: [e.g. Windows] macos
Tfsec Version [e.g. v0.62.0] 0.58.14
tfsec extension 1.74.4

VSCode Version: Version: 1.63.2 Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3 Date: 2021-12-15T09:37:28.172Z (1 mo ago) Electron: 13.5.2 Chromium: 91.0.4472.164 Node.js: 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 19.6.0

Additional context

https://github.com/hashicorp/vscode-terraform/issues/692 https://github.com/hashicorp/vscode-terraform/issues/635

owenrumney commented 2 years ago

I understand what you're saying, but I can replicate and I use the official Terraform plugin

any chance you could do a gif showing the issue and post here?

drewmullen commented 2 years ago

Trying to find a way to replicate consistently. One clarification, the comment toggle seems to be specifically terraform.tfvars files. which uses this language mode:

owenrumney commented 2 years ago

that's weird because the tfsec extension should only interact with the .tf files. I'll have a fiddle too

aquasecurity / vscode-tfsec

TFSEC extension seems to fight hashicorp official for comment toggle #24