Comments about the WCS post

giordano commented 5 years ago

Nice write-up overall! Here are a few comments

[ ] As a general comment, I'd recommend adding links, I couldn't find any in the body of the post. For example, a link to FITSIO.jl, to WCS.jl. Also a relevant link for "World Coordinate System"
[ ] "The WCS info. is present" there is an extra period
[ ] In the "Installation" section, the sentence "or it can be build from source as julia> Pkg.clone("https://github.com/JuliaAstro/WCS.jl")" is misleading. You could for example say "or you can use the development version with pkg> dev WCS"
[ ] Users should never need to use getproperty directly. The usual syntax to access fields just works (and it's just a syntactic sugar for getproperty):
```
julia> wcs.cdelt
2-element Array{Float64,1}:
 -0.066667
  0.066667
```
Similarly for setproperty!, just use wcs.cdelt = [-0.0003, 0.0002] as you already shown above

aquatiko commented 5 years ago

Thnx for your feedback... I will make the changes. Also, would it be good ideas to send a PR there about this link? I will keep adding new stuffs as I learn about the package

giordano commented 5 years ago

Do as you wish, it's your blog :wink:

aquatiko commented 5 years ago

Do as you wish, it's your blog

I meant at WCS.jl README. It lacks proper doc. so this could be a good starter point for newcomers.

aquatiko / aquatiko.github.io

Comments about the WCS post #1