fix: unresponsiveness with long songs

aquelemiguel / parrot

🦜 A hassle-free, highly performant, self-hosted Discord music bot with YouTube and Spotify support. Powered by yt-dlp.

MIT License

136 stars 44 forks source link

fix: unresponsiveness with long songs #165

Closed aquelemiguel closed 2 years ago

aquelemiguel commented 2 years ago

Closes #88.

Decisions

When streaming to the terminal, download progress logs were also getting piped to stdout and then being consumed by Songbird and fed to ffmpeg. Using the -q flag in yt-dlp disables these messages.

Testing

I've only tested this fix on Windows, please @afonsojramos check whether this is now okay on your Linux machine. 🙂

aquelemiguel commented 2 years ago

Haven't tested yet, but I'd say that the comment is removable since -q is a standard flag for quiet across several CLIs and APIs.

@afonsojramos Yeah, but I found it important to state it messes with -o - because someone might try removing it without giving it much thought...

afonsojramos commented 2 years ago

Just tested, doesn't work and my computer exploded.