search

aquelemiguel / parrot

🦜 A hassle-free, highly performant, self-hosted Discord music bot with YouTube and Spotify support. Powered by yt-dlp.
MIT License
136 stars 44 forks source link

Rebase for serenity:0.11.4 and songbird:0.3.0 #197

Closed StaticRocket closed 2 years ago

StaticRocket commented 2 years ago

Well, we should be good to go. There's a lot here. Needs some reviews before I'm comfortable with it.

This just rips out the permission system entirely right now. We should set some safe defaults later.

Resolves #196 Resolves #146

StaticRocket commented 2 years ago

Getting closer. Only obvious thing left is some weird behavior when the user isn't in the same voice channel as the bot. May have mangled permissions somewhere... I'll sort it tomorrow.

afonsojramos commented 2 years ago

Excited to see the changes! Let me know if you need any help! @StaticRocket

StaticRocket commented 2 years ago

@afonsojramos a review when you have time would be great!

joao-conde commented 2 years ago

@StaticRocket alter the workflows too to bump minimal rust version

StaticRocket commented 2 years ago

Huh, I didn't know that information is stored repos now.

StaticRocket commented 2 years ago

What is the best way to add cmake to the base image the docker workflow uses?

afonsojramos commented 2 years ago

What is the best way to add cmake to the base image the docker workflow uses?

I can take a look in a bit if that's the true issue. But if it is just that, it should be easy!

StaticRocket commented 2 years ago

I'm an idiot. I looked at the docker file the other day to try and change the rust version and completely ignored the apt commands specifically installing necessary build tools. We should be good now, cmake is here.

afonsojramos commented 2 years ago

It seems that it was audiopus_sys@v0.2.0 that started having the cmake dependency.