aquelemiguel / parrot

🦜 A hassle-free, highly performant, self-hosted Discord music bot with YouTube and Spotify support. Powered by yt-dlp.
MIT License
136 stars 44 forks source link

fix: address error logging regression #204

Closed StaticRocket closed 2 years ago

StaticRocket commented 2 years ago

Potential solution to #203

This makes create_embed_response clobber previous responses by default. I believe this approach is closer to intended behavior, but an alternative that some might like better is if instead of clobbering the original response it posts as a followup. Looking for feedback here.

I almost wish serenity bit the bullet here and tracked whether an interaction received a response locally. Unfortunately this was the nicest way to do this without adding another call to the discord api.

StaticRocket commented 2 years ago

@aquelemiguel any input on this since it is more of ideological dilemma?

aquelemiguel commented 2 years ago

Hi @StaticRocket, as always thank you for your love for the project. I haven't been active on here for a while, I need a bit to recontextualize myself. I'll get back to you this week still. 🙂

aquelemiguel commented 2 years ago

@StaticRocket Your idea looks good. While we discuss how to handle the errors in @joao-conde's review, personally you can undraft this. 🙂