search

aquelemiguel / parrot

🦜 A hassle-free, highly performant, self-hosted Discord music bot with YouTube and Spotify support. Powered by yt-dlp.
MIT License
136 stars 44 forks source link

Cannot have empty whitelist AND blacklist #228

Open rafaeldamasceno opened 1 year ago

rafaeldamasceno commented 1 year ago

📝 Description

If you try to have empty whitelist AND blacklist at the same time to allow all sources, the bot fills the whitelist with youtube.com, effectively only allowing YouTube as a source.

🪜 Reproduction Steps

  1. Run /managesources and leave both lists empty.
  2. Run /play with a non YouTube source
  3. The "source not allowed" message is printed

ℹ Environment / Computer Info

📸 Screenshots

No response

StaticRocket commented 1 year ago

There's an undocumented trick for this. Add "." As an entry to the blacklist.

rafaeldamasceno commented 1 year ago

Yeah, I do this. Anything goes for the blacklist entry and the whitelist stays empty, but it's not immediate nor intuitive 😄

aquelemiguel commented 1 year ago

@rafaeldamasceno Thank you for the report. Yes, this is sort of an oversight on #223. You can get around it (as you and @StaticRocket both said) but I'm still not entirely happy on how intuitive this command is. Do you (or anyone) have a proposal for a better implementation?