aquifer / aquifer-git

Git deployment for Aquifer.
MIT License
1 stars 4 forks source link

Build should report errors. #1

Closed fluxsauce closed 8 years ago

fluxsauce commented 9 years ago
            if (error) {
              reject();
            }

Really should be

            if (error) {
              Aquifer.console.log(error, 'error');
              reject();
            }
chasingmaxwell commented 8 years ago

@fluxsauce I've fixed this by rejecting with the error reject(error) and then returning it in the callback to aquifer's extension command API. https://github.com/aquifer/aquifer-git/blob/master/bin/index.js#L281